Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Big Float to api.Value #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Big Float to api.Value #93

wants to merge 1 commit into from

Conversation

harshil-goel
Copy link

@harshil-goel harshil-goel commented Sep 16, 2019 •
edited by manishrjain

This change is Reviewable

pullrequest[bot]
pullrequest bot reviewed Sep 16, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.

@harshil-goel you can click here to see the review status or cancel the code review job.

pullrequest[bot]
pullrequest bot reviewed Sep 16, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Message
✅ The description of this pull request is blank. Adding a high-level summary will help our reviewers provide better feedback.

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2019 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

pullrequest[bot]
pullrequest bot reviewed Sep 16, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and adds the new type in the protobuf definition and code

Reviewed with ❤️ by PullRequest

pullrequest[bot]
pullrequest bot reviewed Oct 1, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard

@mangalaman93 mangalaman93 force-pushed the harshil-goel/added-bigfloat-proto branch from ed6febe to c4af0a8 Compare February 9, 2023 10:32
@mangalaman93 mangalaman93 force-pushed the harshil-goel/added-bigfloat-proto branch from c4af0a8 to 72b4d7c Compare March 25, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pullrequest pullrequest[bot] pullrequest left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@harshil-goel harshil-goel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harshil-goel @CLAassistant