-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NumPy as a hard dependency #204
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far! Do you understand the test failures, is that just an env thing?
I didn't get to every test yet. I'll hack a bit this weekend. |
@janeyx99 Is this still of interest to Torch? I think we're relatively close on removing that last of the NumPy dependancies. |
Yes! Removing the last dependencies would be awesome! |
Apologies- I started a new job. This is in my mind and I hope to hack a little tomorrow night! |
@janeyx99 I'm looking to push another release shortly, is this still a requested feature? |
@dgasmith yes, torch still doesn't have a hard dependency on numpy (our tests do) so this is still desirable! Sorry it took a week to get back to you--this fell in my personal inbox. |
I'll get in #232 first and then finalize this PR. It will be quite tidy to have no formal dependancies. |
Description
This PR removes NumPy from opt_einsum as a runtime dependency. The change has little effect on the opt_einsum code base but significantly effects the testing infrastructure. Several testing strategies are currently employed to help understand the most effective one. Currently, these are:
testing.py
module withpytest.skip
pytest.skip
functions wrapped in decoratorsFeedback welcome!
Todos
Notable points that this PR has either accomplished or will accomplish.
tensordot
codeimport numpy
frompossibly_convert_to_numpy
ssa_to_linear
with a proper implementationQuestions
Status