Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imports without "only" #1382

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jubich
Copy link
Member

@jubich jubich commented Feb 1, 2024

I have noticed that the following import is not reached even if it is compiled with the "WITH_MPI" flag.

#:if WITH_MPI
use dftbp_common_mpienv
#:endif

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.65%. Comparing base (206db78) to head (05e564d).
Report is 16 commits behind head on main.

❗ Current head 05e564d differs from pull request most recent head 23fbf03. Consider uploading reports for the commit 23fbf03 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
- Coverage   70.86%   70.65%   -0.21%     
==========================================
  Files         231      231              
  Lines       44203    43915     -288     
==========================================
- Hits        31323    31029     -294     
- Misses      12880    12886       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aradi aradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure, that you align with our style guide everywhere. I see several continuation lines with incorrect indentation (should be 4 characters). Also, you can use line lengths up to 100 characters.

@aradi
Copy link
Member

aradi commented Apr 9, 2024

Perfect, could you please re-base it to current main, and then we can merge it. (Sorry for taking so long...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants