Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing-related error propagation #1306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vanderhe
Copy link
Member

Some parsing-related, systematic propagation of errors; needs discussion next devel. meeting.

@vanderhe vanderhe force-pushed the parserErrprop branch 3 times, most recently from 8e3c82c to bf37788 Compare August 29, 2023 09:39
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Attention: 819 lines in your changes are missing coverage. Please review.

Comparison is base (d276fa6) 69.79% compared to head (a3fde6f) 68.61%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
- Coverage   69.79%   68.61%   -1.18%     
==========================================
  Files         227      227              
  Lines       42522    43215     +693     
==========================================
- Hits        29679    29654      -25     
- Misses      12843    13561     +718     
Files Coverage Δ
app/dftb+/dftbplus.F90 100.00% <100.00%> (ø)
app/modes/modes.F90 75.60% <100.00%> (+0.19%) ⬆️
app/phonons/phonons.F90 56.83% <100.00%> (+0.23%) ⬆️
src/dftbp/api/mm/mmapi.F90 77.10% <100.00%> (+0.10%) ⬆️
src/dftbp/dftb/elecconstraints.F90 98.57% <100.00%> (ø)
src/dftbp/dftbplus/parser.F90 70.24% <ø> (-7.50%) ⬇️
src/dftbp/dftbplus/hsdhelpers.F90 88.88% <81.81%> (-1.59%) ⬇️
src/dftbp/dftbplus/specieslist.F90 87.50% <77.77%> (-4.50%) ⬇️
src/dftbp/dftbplus/input/fileaccess.F90 75.00% <42.85%> (-10.72%) ⬇️
src/dftbp/io/hsdutils2.F90 78.26% <30.76%> (-2.83%) ⬇️
... and 10 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant