Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for full rank yerr, not just diagonal. #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ixkael
Copy link

@ixkael ixkael commented Jan 23, 2017

Added support (and tests) for full yerr, not just diagonal. Happy to add more tests.

@dfm
Copy link
Owner

dfm commented Jan 30, 2017

Thanks Boris! This is interesting and I can see the use but I don't think that it's right to call this "yerr" because it's more like the measurement "covariance". I'd prefer to add it as a separate parameter - maybe a kwarg called cov or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants