New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infer named parameter layout from dict-type initial_state #463

Open

zachjweiner wants to merge 2 commits into dfm:main from zachjweiner:allow-dict-input-state

zachjweiner commented Mar 6, 2023

Here's a first attempt (tests, etc., will have to come another day). Some notes:

This remains backwards-compatible with parameter_names, but I'm happy to axe it entirely if you aren't committed to parameter_names as supported without deprecation.
Setting state (self.param_slice_shape) after __init__ isn't ideal, but I'm not sure how else to get that info to compute_log_prob.

zachjweiner and others added 2 commits

March 5, 2023 16:17


          infer named parameter layout from dict-type initial_state

cc68011


          [pre-commit.ci] auto fixes from pre-commit.com hooks

d689416

for more information, see https://pre-commit.ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment