Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code to newer standards, requiring php 8.1 and fix deprecations #12

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

AnnaDamm
Copy link

@AnnaDamm AnnaDamm commented Mar 4, 2024

fixes #11

more details, see CHANGELOG.md

@simensen
Copy link
Member

simensen commented Mar 4, 2024

@AnnaDamm Thank you for taking the time to make this change! Are you actively using this in any projects? I'd love to see where it's being used. :)

Since most of the files showed up as deleted and recreated (ugh, git, right?), it is hard for me to evaluate what's changed here. Nothing looks off at first glance, but I'll need some time to consider this.

In the meantime, can you also add a change to composer.json to add an additional branch alias? I think these changes warrant a 2.x release. How do you feel about that?

"dev-main": "2.0.x-dev"

@simensen
Copy link
Member

simensen commented Mar 4, 2024

Oh, to be clear, the main branch does not exist yet. If I get to the point where I merge this, this branch will become main.

@AnnaDamm
Copy link
Author

AnnaDamm commented Mar 5, 2024

@simensen Thanks for looking at it. They show up as changed because I moved the files according to psr-0 to psr-4.
Sorry, I didn't consider it showing up as deleted/created in github, or i would have done it in a separated commit for easier review.

As to your question of where we use it: our company uses an hr tool with a REST-API that is using HAWK as their authentication method. We consume this API using your library here. it is also mentioned in their "how to use this rest api" documentation for php: https://documenter.getpostman.com/view/799228/absenceio-api-documentation/2Fwbis#authentication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants