Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloundFoundry connector #1624

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

CloundFoundry connector #1624

wants to merge 13 commits into from

Conversation

xtremerui
Copy link
Contributor

Support for authenticating against CloudFoundry

Documentation of CloudFoundry UAA server

cc @pivotal-jwinters

@xtremerui xtremerui mentioned this pull request Jan 13, 2020
Open
@julia-pu julia-pu force-pushed the pr/add-cf-connector-sync branch 3 times, most recently from 47c7199 to 556cf89 Compare January 13, 2020 18:56
@xtremerui
Copy link
Contributor Author

Hi, just checking back. Since there is no feedback here yet so I am wondering are there certain requirements to meet for Dex to add a new connector? Is there a way to move forward for this PR or its just a simple Nah not this connector?

Thank you for your time.

@Albertoimpl
Copy link

Our team is also interested in this connector to adopt dex.
I saw it used to be supported but seems to be gone now: https://github.com/dexidp/dex/pull/542/files
Is there anything we can do to move this forward?
Thanks!

@mvdkleijn
Copy link
Contributor

@xtremerui This also has merge conflicts... 😄

@xtremerui xtremerui force-pushed the pr/add-cf-connector-sync branch 2 times, most recently from efa3156 to ed22ce5 Compare August 4, 2020 19:02
@xtremerui xtremerui force-pushed the pr/add-cf-connector-sync branch 2 times, most recently from 526f2ed to 5549159 Compare September 28, 2020 19:39
@xtremerui xtremerui force-pushed the pr/add-cf-connector-sync branch 3 times, most recently from c7bbcf4 to 4e238e8 Compare October 5, 2020 17:39
@xtremerui xtremerui force-pushed the pr/add-cf-connector-sync branch 3 times, most recently from 8d44c14 to d2b321f Compare November 5, 2020 04:17
@xtremerui
Copy link
Contributor Author

xtremerui commented Mar 5, 2021 •
edited

@sagikazarmark I kown there must be lots of pending PRs in your list. Just wanted to get some feedback here so we could move forward. Thx!

We assume that a PR to dexidp/website to include the doc is needed. Then we will update README.md here.

@xtremerui xtremerui force-pushed the pr/add-cf-connector-sync branch 2 times, most recently from 632cdf8 to acc2c20 Compare November 16, 2021 00:07
@xtremerui xtremerui force-pushed the pr/add-cf-connector-sync branch 2 times, most recently from 7d0ae05 to aa82d4f Compare February 8, 2022 20:43
@sagikazarmark sagikazarmark added area/connector release-note/new-feature Release note: Exciting New Features labels Oct 3, 2022
sagikazarmark
sagikazarmark requested changes Oct 3, 2022
View reviewed changes
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits

connector/cf/cf.go Outdated Show resolved Hide resolved
connector/cf/cf.go Outdated Show resolved Hide resolved
@sagikazarmark
Copy link
Member

@xtremerui let me know if you think this is ready.

And you are right: some sort of documentation would be nice. At least adding it to the list of connectors.

@xtremerui xtremerui force-pushed the pr/add-cf-connector-sync branch 3 times, most recently from b08eada to 177adac Compare October 5, 2022 03:22
@xtremerui
Copy link
Contributor Author

@sagikazarmark the PR is updated. Thx for the reviewing.

We will submit a PR to dex docs too. BTW, in the readme https://dexidp.io/docs/connectors/oauth/ is somehow broken as in the connector listing, though the PR for oauth doc is already merged.

@xtremerui xtremerui force-pushed the pr/add-cf-connector-sync branch 2 times, most recently from 0e89bf8 to e81d9df Compare October 31, 2022 15:02
@nabokihms nabokihms mentioned this pull request Feb 17, 2023
Open
@xtremerui xtremerui mentioned this pull request Mar 9, 2023
Closed
Joshua Winters and others added 13 commits April 9, 2024 11:56
Add new connector for Cloudfoundry
a782596 
- Verifies user is part of orgs and spaces for group claims

Signed-off-by: Joshua Winters <jwinters@pivotal.io>
Co-authored-by: Shash Reddy <sreddy@pivotal.io>
update cf connector to use 'authorization_endpoint' from /v2/info
939196e 
Co-authored-by: Topher Bullock <tbullock@pivotal.io>
Signed-off-by: Josh Winters <jwinters@pivotal.io>
@daniellavoie
Added support for CF resources pagination
572844a 
Signed-off-by: Daniel Lavoie <dlavoie@live.ca>
cf: add org to groups claims
a48bcc4 
Signed-off-by: Joshua Winters <jwinters@pivotal.io>
Co-authored-by: Rui Yang <ryang@pivotal.io>
cf: add org guid to groups claims
31a750e 
Co-authored-by: Rui Yang <ryang@pivotal.io>
Signed-off-by: Joshua Winters <jwinters@pivotal.io>
add unit test and api call to audited_spaces and managed_spaces
d1cafa2 
Signed-off-by: Zoe Tian <ztian@pivotal.io>
Co-authored-by: Ciro S. Costa <cscosta@pivotal.io>
Signed-off-by: w3tian <w3tian@uwaterloo.ca>
append role to space guids
03d4438 
Signed-off-by: Rui Yang <ryang@pivotal.io>
Co-authored-by: Joshua Winters <jwinters@pivotal.io>
add cf org:space:role group claim to token
ebc8357 
Signed-off-by: Joshua Winters <jwinters@pivotal.io>
Co-authored-by: Rui Yang <ryang@pivotal.io>
fix lint errors
ea1984f 
gofumpt-ed

Signed-off-by: Rui Yang <ryang@pivotal.io>
run golangcli-lint
d589ac5 
Signed-off-by: Rui Yang <ruiya@vmware.com>
fix sanity check errors
479004f 
Signed-off-by: Rui Yang <ruiya@vmware.com>
rename connector;make types private;
531f468 
Signed-off-by: Rui Yang <ruiya@vmware.com>
add cloudfoundry to connector list in readme
badb67e 
Signed-off-by: Rui Yang <ruiya@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/connector release-note/new-feature Release note: Exciting New Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xtremerui @Albertoimpl @mvdkleijn @sagikazarmark @daniellavoie