Rbac related bug fixing which biforcates the apps and jobs permission #5110

Kishan789dev · 2024-05-13T21:50:29Z

Desription

fixed the issue related user permission ,user having permisssion for the view only was able to create app/job

Checklist:

I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.

-->

* grpc error handling * fix

* terminate operation before sync * using method for checking manual sync * terminating only in case of error * handling termination error * updating sync function

…5012) * fixed * code review comments

…4978) * introuddced api token versioning * fix * reverted wire_gen * migration udpated and minor refactor * refactor * moved const from apiToken pkg to user * reverted wire_gen * refactor * reverted wire_gen * concurrency case handled * fix * commented wherever necessary * refactor * fix * refactor * refactor * wip * refactor * added comments and minor refactor * refactor * refactoring * fix * added comments around cyclic import * added few more comments * sql script no updated

* introduction to feasibility * moved feasibility in trigger/devtronApps * feasibility refactorings * refactoring and feasibility manager * removing vulnerability changes * vulnerability checks retract * dry run removed * dry run checks removed * refactoring * removing unnecessary code * comments * trigger request

* Changes made in the doc according to the newer version * Revert "Changes made in the doc according to the newer version" This reverts commit 1f4d806. * created a doc for the newer version of the plugin * added the pass/fail condition * corrected mistakes

* Update DockerfileEA * Update Dockerfile

* Changes made in the doc according to the newer version * Revert "Changes made in the doc according to the newer version" This reverts commit 1f4d806. * created a doc for the newer version of the plugin * added the pass/fail condition * corrected mistakes * added the new doc in the index file

…cronjob template charts (#5016) * handle for wrong format of k8s version in semvercompare func in cronjob template charts * TestStripPrereleaseFromK8sVersion UT's added * constants added * incorporated code review changes * merge main

* Add files via upload CD plugin * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Rename 231_devtron_CD_trigger_v1.0.0.down.sql to 238_devtron_CD_trigger_v1.0.0.down.sql * Rename 231_devtron_CD_trigger_v1.0.0.up.sql to 238_devtron_CD_trigger_v1.0.0.up.sql * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Rename 238_devtron_CD_trigger_v1.0.0.down.sql to 240_devtron_CD_trigger_v1.0.0.down.sql * Rename 238_devtron_CD_trigger_v1.0.0.up.sql to 240_devtron_CD_trigger_v1.0.0.up.sql --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>

* closing channel after write operation * removing close * using buffered channel * wip: making done channel bufferred * terminal racecondition and deadlock fix * wire run * removing done send call * updating bound channel send function

* git material flow added in transaction * wire refactored * code review comments incorporated * code review comments incorporated * code review comments incorporated

* wip * error handling done * fix --------- Co-authored-by: ayushmaheshwari <ayush@devtron.ai>

* feat: Plugin to trigger Devtron Job (#5052) * Update 241_devtronJobTrigger.up.sql

* handle context cancelled and deadline exceeded in fetch resource tree api * handle context cancelled and deadline exceeded error for resource tree fetch api for acd deployment * handle context cancelled and deadline exceeded error sync argo app with normal refresh * revert TIMEOUT_IN_SECONDS * revert bean TimeoutSlow param * fix

* cherry-pick * incorporating feedbacks

* Update azure-devops-issue-sync.yml * Update chart-sync.yaml * Update create-release.yml * Update enterprise-repo-sync.yaml * Update pager-duty-issue-escalate.yaml * Update update-release-notes.yml * Update chart-sync.yaml * Update create-release.yml * Update enterprise-repo-sync.yaml * Update update-release-notes.yml * Update enterprise-repo-sync.yaml --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>

Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com>

)

* added sql for relese feat * updated sql script no * renamed sql files * updated schema for release & release track * fixes in schema * updated schema * made changes in old schemas * enum correction * minor change in script * sql script update * updated script * updated sql script no * exposed release resource * updated sql script no * updated release catalog data * added rescind status change policy handling * renaming policy json field * updated schema ordering * updated global policy version * updated policy json * prod bug fix * updated policy lock status * added action check policy release * wip * updated policy for release status * updated down sql * updated sql script no. * fixed autocorrect issues * added first released on key for release * updated task run migration * Added task run down migration * sql script change * updated policy for action check - instruction patch * fixed schema merge conflict --------- Co-authored-by: Shivam-nagar23 <shivam@devtron.ai>

github-actions · 2024-05-13T22:41:23Z

PR is not linked to any issue, please make the corresponding changes in the body.

github-actions · 2024-05-14T14:06:08Z

PR is not linked to any issue, please make the corresponding changes in the body.

kartik-579 · 2024-05-22T13:44:05Z

api/restHandler/app/pipeline/configure/BuildPipelineRestHandler.go


+	} else {
+		appRbacOk = handler.enforcer.Enforce(token, casbin.ResourceApplications, casbin.ActionTrigger, appObject)
+	}
 	if !appRbacOk {
 		handler.Logger.Debug(fmt.Errorf("unauthorized user"), "Unauthorized User", http.StatusForbidden)
 		common.WriteJsonResp(w, err, "Unauthorized User", http.StatusForbidden)


only valid for devtron applications, should skip for jobs

from line ~610 to 633

changes incorporated

gitguardian · 2024-05-22T14:12:59Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10190660	Triggered	Generic Password	`8581fbe`	tests/integrationTesting/devtron-secret.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

sonarcloud · 2024-05-22T14:13:55Z

Quality Gate failed

Failed conditions
29.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Kishan789dev added 4 commits April 24, 2024 17:39

issue has been on code level

0a17d7e

added the changes

551be0b

Merge branch 'main' into bug-8893

a1ec9fe

changes made to fix the bug is done

7852e4c

Kishan789dev requested review from vikramdevtron, kripanshdevtron and nishant-d as code owners May 13, 2024 21:50

github-actions bot added the PR:Issue-verification-failed label May 13, 2024

Kishan789dev and others added 22 commits May 14, 2024 03:21

Delete go.sum

1ceec13

Delete go.mod

ec64adb

fix: grpc error handling for TemplateChart req (#4980)

6b36ba2

* grpc error handling * fix

fix: terminate sync if in progress (#4946)

68a0fb6

* terminate operation before sync * using method for checking manual sync * terminating only in case of error * handling termination error * updating sync function

fix: Kubelink Requests getting Failed for gRPC method GetAppDetails (#…

0b4ea83

…5012) * fixed * code review comments

added failed workflow in ISLastReleaseStopType method (#5005)

64d6d9e

fix: Dockerfile ubuntu version (#5022)

3422f9e

* Update DockerfileEA * Update Dockerfile

fix: terminal stuck in connecting state (#4989)

d5984b7

* closing channel after write operation * removing close * using buffered channel * wip: making done channel bufferred * terminal racecondition and deadlock fix * wire run * removing done send call * updating bound channel send function

panic handled (#5036)

85a15cd

fix: git material saved in transaction (#5040)

4e89e69

* git material flow added in transaction * wire refactored * code review comments incorporated * code review comments incorporated * code review comments incorporated

fix: App create api validations (#5019)

5727e13

* wip * error handling done * fix --------- Co-authored-by: ayushmaheshwari <ayush@devtron.ai>

gitops update updated (#5055)

9ca82f9

feat: Plugin to trigger Devtron Job (#5053)

0037d1c

* feat: Plugin to trigger Devtron Job (#5052) * Update 241_devtronJobTrigger.up.sql

feat: resource scan (#4977)

dbc2721

* cherry-pick * incorporating feedbacks

sync with main

df1517b

jatin-jangir-0220 and others added 10 commits May 14, 2024 03:41

fix (#5074)

33acf34

gitops validation in api (#5082)

99b3381

condition fix (#5088)

17032ee

handled namespace case if deleted by kubectl (#5081)

0bcf3b9

Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com>

resolved PR review comments also remove check for virtual cluster (#5095

25eb9e2

)

sync with main

b500946

final fixes done

cea649a

final code ready fo the pr

7930d89

Kishan789dev requested review from prakarsh-dt, ashokdevtron and uxarya-d as code owners May 13, 2024 22:17

Merge branch 'main' into rback-related-bug

3bfba54

Kishan789dev changed the title ~~Rback related bug~~ Rback related bug fixing May 13, 2024

devtron-labs deleted a comment from sonarcloud bot May 13, 2024

Merge remote-tracking branch 'origin/main' into rback-related-bug

038c3bd

github-actions bot added PR:Ready-to-Review and removed PR:Issue-verification-failed labels May 17, 2024

Kishan789dev added 2 commits May 22, 2024 18:52

changes suggested are incorporated

0a0966d

missed changes in a file from above commit are added and committing now

dbc2d05

kartik-579 requested changes May 22, 2024

View reviewed changes

Kishan789dev added 2 commits May 22, 2024 19:41

changes done for adding a if condition for apps

55b0138

Merge branch 'main' into rback-related-bug

8581fbe

Kishan789dev changed the title ~~Rback related bug fixing~~ Rbac related bug fixing which biforcates the apps and jobs permission May 22, 2024

vikramdevtron approved these changes May 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rbac related bug fixing which biforcates the apps and jobs permission #5110

Rbac related bug fixing which biforcates the apps and jobs permission #5110

Kishan789dev commented May 13, 2024 •

edited by vikramdevtron

github-actions bot commented May 13, 2024

github-actions bot commented May 14, 2024

kartik-579 May 22, 2024

kartik-579 May 22, 2024

Kishan789dev May 22, 2024

gitguardian bot commented May 22, 2024

sonarcloud bot commented May 22, 2024

Rbac related bug fixing which biforcates the apps and jobs permission #5110

Are you sure you want to change the base?

Rbac related bug fixing which biforcates the apps and jobs permission #5110

Conversation

Kishan789dev commented May 13, 2024 • edited by vikramdevtron

Desription

Checklist:

github-actions bot commented May 13, 2024

github-actions bot commented May 14, 2024

kartik-579 May 22, 2024

Choose a reason for hiding this comment

kartik-579 May 22, 2024

Choose a reason for hiding this comment

Kishan789dev May 22, 2024

Choose a reason for hiding this comment

gitguardian bot commented May 22, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

sonarcloud bot commented May 22, 2024

Quality Gate failed

Kishan789dev commented May 13, 2024 •

edited by vikramdevtron