Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added a check for restricting managers to assign superadmin through permission groups #5025

Merged
merged 12 commits into from May 17, 2024

Conversation

ashishdevtron
Copy link
Contributor

@ashishdevtron ashishdevtron commented Apr 29, 2024

Description

added check, no one other than super admin can assign super-admin role

Fixes #5026

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Shivam-nagar23
Shivam-nagar23 previously approved these changes Apr 29, 2024
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ashishdevtron ashishdevtron merged commit 0eea3f5 into main May 17, 2024
7 checks passed
@ashishdevtron ashishdevtron deleted the manager-superadmin-fix branch May 17, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [Prod]Manager is able to make superadmin through permission groups
3 participants