This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Go Modules, Fixes & Tests for devopsdays-cli #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SourceLevel has finished reviewing this Pull Request and has found:
|
- Setup Go Modules - Remove Dep requirement - Fix some issues with tests - Use raw.github.com (even though headers not rendered for time being) - Update goconvey. - Add Dockerfile changes Signed-off-by: Christopher Mills <chris.mills@enginegroup.com>
|
I think this is there now @mattstratton, can you see anything I've missed? (other than better code hub being horrible to me) |
Signed-off-by: Chris Mills <chris.mills@enginegroup.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
The cli no longer built due to deprecation. With Go moving towards modules by default and go dep fell out of favour building the packages and version of Go needed updating.
How is the fix applied?
I moved the cli to use Go modules, along with Travis and used GOPROXY just incase. Altered the Dockerfile to use multiple stages and removed deprecation from goreleaser. I also had to alter the Makefile significantly and fix some failing parts of the application.
What GitHub issue(s) does this PR fix or close?
Fixes #143
Fixes #140
Fixes #131
Fixes #135
This change is
Edit: Force pushed to solve issue with signed commits
Edit: Added changes for some other quick tickets and altered PR text to focus on fixes.