Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder quad vertices #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jtothebell
Copy link

Fixes #40 . Credit Antoine for the fix and @DPS2004 for finding and reporting original issue.

Fixes a visual issue when updating a texture. Credit Antoine for the fix
@fincs
Copy link
Member

fincs commented May 21, 2022

All this does is changing the diagonal by which the quad is split into two triangles. In theory, both ways to split the quad should result in equivalent rendering. Are you sure you don't have other issues such as Z-fighting, or data races that affect when your texture is being read by the GPU vs when it's written by the CPU?

@jtothebell
Copy link
Author

jtothebell commented May 21, 2022

I agree, it seems like an odd fix and I'm unsure why it works. But there shouldn't be any Z fighting because there is only one texture and one quad. I don't think there would be a data race either since it is not multi threaded, but maybe I'm doing something wrong. The repro case is attached to the bug report (#40)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step like texture artifacts when updating texture every frame
2 participants