Add unknown orientation variant #411
Open
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zandor300 I don't believe any of the CI should fail, and it appeared to fail when trying to download Ruby. Is it worth you re-running the CI? |
|
@GeorgeElsham Is it possible for you to update your PR from master? I've fixed the CI test jobs. Someone removed the ruby version we were using and that is fixed on master. Danger job is broken when running on a PR that merges from a fork so don't mind that. |
|
I've not really dealt with using forks and pull requests on GitHub. I used GitHub's "Sync fork" button but it seems to have merged your master into my PR branch. If this is okay, we can continue. Otherwise, let me know if I should rebase instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #410