You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In some cases when the orientation is neither landscape nor portrait, the reported orientation from orientation is .portrait. The orientation can be neither in some cases such as during Xcode previews after a reload when the device is already in landscape, though that also seems like a bug in Xcode previews reporting the wrong orientation.
This issue is caused by only checking if the orientation is landscape or not:
In some cases when the orientation is neither landscape nor portrait, the reported orientation from
orientation
is.portrait
. The orientation can be neither in some cases such as during Xcode previews after a reload when the device is already in landscape, though that also seems like a bug in Xcode previews reporting the wrong orientation.This issue is caused by only checking if the orientation is landscape or not:
DeviceKit/Source/Device.generated.swift
Lines 1869 to 1875 in 4b85958
I would expect an
.unknown
orientation variant. This can be a breaking change, however, I would say a minor version bump is fine because:switch
, the user doesn't care about other possible variants, and so this code won't affect themswitch
, Xcode will give a compiler error, and is a very quick fixThe text was updated successfully, but these errors were encountered: