Update dependency to newer version of virtualenv #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the purposes of longevity of this project.
USe newer version of virtualenv, because change.
|
Really we should drop using local copies of software entirely, since this was a hangover from days when we couldn't mirror pypi at all. I'm a little worried about the "hopefully" in the PR message. Has this actually been tested? There's no point in merging this until it has. |
|
Yes, it has been tested on my machine. |
|
What do you mean by 'tested', though? @jaylett |
|
It works on my machine ('localhost', not 'live') |
|
I've eliminated bundled dependencies in 9e3335e. This may still cause problems (very old Django, for instance!), but should at least use recent pip & virtualenv so avoiding the problems you had. Feel free to open another PR if you run into problems and are able to solve them! |
|
Thanks for the effort on this, @jaylett |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses problems that might occur with Python, 64-bit Ubuntu and virtualenv. The following are examples: