Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maven wrapper script instead of the mvn in java-quarkus commands #399

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented May 16, 2024

What does this PR do?:

In order to fix the maven build in the java quarkus sample, modify the devfile commands with maven wrapper script instead of the pure mvn call, see: eclipse-che/che#22961

Which issue(s) this PR fixes:

fixes eclipse-che/che#22961
fixes devfile/api#1541

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented May 16, 2024

Hi @vinokurig. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michael-valdron
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added the lgtm Looks good to me label May 16, 2024
@maxandersen
Copy link
Collaborator

That works, but what's there reason the default is 3.8.5?

@vinokurig
Copy link
Contributor Author

That works, but what's there reason the default is 3.8.5?

This is the maven version from the image: registry.access.redhat.com/ubi8/openjdk-17:1.18-2

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend omitting changes to deprecated stack versions.

Otherwise, changes looks good to me.

@vinokurig
Copy link
Contributor Author

@michael-valdron All the java-quarkus devfiles have been updated.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-valdron All the java-quarkus devfiles have been updated.

I'd recommend omitting these changes for deprecated versions 1.3.0 and 1.4.0, change is minor so I won't let this block the PR.

I can approve once the stack owner has signed off.

cc @maxandersen

Signed-off-by: ivinokur <ivinokur@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label May 21, 2024
@vinokurig
Copy link
Contributor Author

@michael-valdron

I'd recommend omitting these changes for deprecated versions 1.3.0 and 1.4.0, change is minor so I won't let this block the PR.

Sorry, I misunderstood your previous comment, reverted the 1.3.0 and 1.4.0 versions.

@lmilbaum
Copy link
Contributor

issues are not enabled on this repo. Piggy backing on this PR.
Please opt-out the platform-engineering-bot user. It is replaced by a renovate team bot user.

@michael-valdron
Copy link
Member

issues are not enabled on this repo. Piggy backing on this PR. Please opt-out the platform-engineering-bot user. It is replaced by a renovate team bot user.

Continuing this thread here: devfile/api#1565 (comment)

@thepetk
Copy link
Contributor

thepetk commented May 23, 2024

/retest

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just need stack owner @maxandersen approval

Copy link
Collaborator

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 though this means it will use the non-product supported maven.

@openshift-ci openshift-ci bot added the lgtm Looks good to me label May 27, 2024
@vinokurig
Copy link
Contributor Author

@michael-valdron Could you please merge the PR if you do not have any objections?

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibuziuk, maxandersen, michael-valdron, vinokurig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 4, 2024
@michael-valdron michael-valdron merged commit 3d325b7 into devfile:main Jun 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants