-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use maven wrapper script instead of the mvn in java-quarkus commands #399
Conversation
Hi @vinokurig. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
77eb0aa
to
8c282d0
Compare
/ok-to-test |
That works, but what's there reason the default is 3.8.5? |
This is the maven version from the image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend omitting changes to deprecated stack versions.
Otherwise, changes looks good to me.
@michael-valdron All the java-quarkus devfiles have been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-valdron All the java-quarkus devfiles have been updated.
I'd recommend omitting these changes for deprecated versions 1.3.0
and 1.4.0
, change is minor so I won't let this block the PR.
I can approve once the stack owner has signed off.
cc @maxandersen
Signed-off-by: ivinokur <ivinokur@redhat.com>
8c282d0
to
4d3e983
Compare
Sorry, I misunderstood your previous comment, reverted the |
issues are not enabled on this repo. Piggy backing on this PR. |
Continuing this thread here: devfile/api#1565 (comment) |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just need stack owner @maxandersen approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 though this means it will use the non-product supported maven.
@michael-valdron Could you please merge the PR if you do not have any objections? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibuziuk, maxandersen, michael-valdron, vinokurig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
In order to fix the maven build in the java quarkus sample, modify the devfile commands with maven wrapper script instead of the pure
mvn
call, see: eclipse-che/che#22961Which issue(s) this PR fixes:
fixes eclipse-che/che#22961
fixes devfile/api#1541
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: