chore: use https protocol and update devfile scheme to 2.2.2 for dotnetcore31 and angular #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
svor
reviewed
May 15, 2024
There was a problem hiding this comment.
About nodejs-angular stack, you don't need to make changes for all devfiles. Just create a new folder 2.2.1 and put into it a devfile with your changes, then add this version into stack.yaml file and mark it as a default
ibuziuk
reviewed
May 16, 2024
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
svor
reviewed
May 17, 2024
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
ibuziuk
approved these changes
May 22, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, svor, vitaliy-guliy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
Updated
dotnetcore31andnodejs-angulardevfiles.Linked with devfile-samples/devfile-stack-nodejs-angular#3
.NET Core 3.1
Angular 2.0.2, 2.1.0, 2.2.0
Which issue(s) this PR fixes:
Link to github issue(s)
Part of eclipse-che/che#22869
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: