Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [Devtools Week] Create registry-support devfile workspace #195

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

michael-valdron
Copy link
Member

Please specify the area for this PR

index server
oci registry

What does does this PR do / why we need it:

Adds a devfile to the registry-support repository for building and deploying the devfile registry service using innerloop and outerloop deployment scopes.

In addition, adds checks on devfile using odo v3.

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1069

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

commit 5a5f1a0
Author: Michael Valdron <mvaldron@redhat.com>
Date:   Thu Apr 27 19:21:54 2023 -0400

    Copy default config.yml file for cases of not having any to provide.

    Signed-off-by: Michael Valdron <mvaldron@redhat.com>

commit 9660f43
Author: Michael Valdron <mvaldron@redhat.com>
Date:   Fri Mar 17 18:40:55 2023 -0400

    registry-support devfile added.

    Signed-off-by: Michael Valdron <mvaldron@redhat.com>

commit 67b8bd5
Author: Michael Valdron <mvaldron@redhat.com>
Date:   Fri Apr 14 00:15:54 2023 -0400

    add registry config file.

    Signed-off-by: Michael Valdron <mvaldron@redhat.com>

commit dc76b9d
Author: Michael Valdron <mvaldron@redhat.com>
Date:   Fri Mar 17 18:39:57 2023 -0400

    odo ignores added.

    Signed-off-by: Michael Valdron <mvaldron@redhat.com>

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Copy link

openshift-ci bot commented Dec 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2023
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35722ec) 35.58% compared to head (aad3c73) 35.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   35.58%   35.58%           
=======================================
  Files           7        7           
  Lines        1360     1360           
=======================================
  Hits          484      484           
  Misses        829      829           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress
Projects
None yet
1 participant