Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry-operator release automation #75

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Jdubrick
Copy link
Contributor

Please specify the area for this PR
Release automation

What does does this PR do / why we need it:
This PR automates the tasks undertaken during the release process for registry-operator. It replaces all of the version numbers with the new release version, commits the changes, and opens a pull request for the release to the proper release branch. If the new release being cut is a major this script will create a new branch to house this new major release. For all minor and patch releases it will open the PR to its respective branch.

Updating the release process documentation was not in the acceptance criteria for this issue so I have opened an issue to address changes to be made: devfile/api#1421

Which issue(s) this PR fixes:
fixes devfile/api#1326

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

  • Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:
After changes to the old release is made to include the entire git history we will need to do a sanity check test to ensure the script can access the devfile repo properly. All testing up to this point has been to a forked repo and I am unsure if there will be any unforeseen complications with permissions when going to devfile.

Until these changes and sanity check has been made we should not merge this PR.

cc: @michael-valdron

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f55ab8e) 25.30% compared to head (574d46d) 26.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   25.30%   26.43%   +1.13%     
==========================================
  Files          25       25              
  Lines        1415     1415              
==========================================
+ Hits          358      374      +16     
+ Misses       1032     1020      -12     
+ Partials       25       21       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@thepetk
Copy link
Contributor

thepetk commented Jan 23, 2024

/hold

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange I had the impression that if we hold the merge option automatically gets blocked. Might be good to update this PR to draft so we are sure we cannot merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants