Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: pin stow to version 2.3.1 #172

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

AObuchow
Copy link
Contributor

Stow recently released version 2.4.0, which does not allow stowing absolute symbolic links. As a temporary workaround, this PR downgrades stow back to version 2.3.1.

Stow is being downloaded from a GNU mirror, and then verified using the official GNU keyring (see the bottom of https://ftp.gnu.org/README). We remove the GNU gpg related files once we're done with them.

Unfortunately, the binary of stow is not available for direct usage, so stow is built and then moved to /usr/bin/ so that it is available on $PATH to be used for the rest of the UBI & UDI builds (moving stow to /usr/local/bin/ didn't seem to put it on $PATH).

Fixes eclipse-che/che#22957

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AObuchow, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AObuchow
Copy link
Contributor Author

@ibuziuk @SDawley any thoughts on this? My only nitpick with this PR is the addition of make to the ubi. If there are no complaints, I'll have this merged as it's required to fix the UDI builds, and is a blocker for #171

@SDawley
Copy link
Contributor

SDawley commented May 14, 2024

@AObuchow So long as this is the upstream solution, looks good to me.
curl won't work downstream though.

@AObuchow
Copy link
Contributor Author

@AObuchow So long as this is the upstream solution, looks good to me. curl won't work downstream though.

Sounds good :) Downstream, we are manually building stow from sources. Currently, it seems like the version of stow being git cloned downstream is old so this issue hasn't arisen downstream. However, we might have to manually pin the commit to use for stow downstream if that commit is being automatically updated.

@AObuchow AObuchow merged commit 8627963 into devfile:main May 14, 2024
2 checks passed
@AObuchow AObuchow deleted the downgrade-stow branch May 14, 2024 15:00
@AObuchow
Copy link
Contributor Author

Looks like I messed up when copying over the /usr/share/ files 😅 as stow is still looking for them in /tmp/.../build/share/

image

Will look into this further tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants