New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] adding compose component to devfile/api #882
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kernelpanic77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Angel Misevski <amisevsk@redhat.com>
Co-authored-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: kernelpanic77 <shanware.ishan@gmail.com>
Signed-off-by: kernelpanic77 <shanware.ishan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have provided some suggestions. Those should be applied to v1alpha1 too.
// Allows importing into the devworkspace docker-compose files | ||
// defined in a given manifest. For example this allows the reuse of previously | ||
// docker-compose files used to define configuration for managing | ||
// multiple containers at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to address the points raised (rightfully) by @amisevsk
// Allows importing into the devworkspace docker-compose files | |
// defined in a given manifest. For example this allows the reuse of previously | |
// docker-compose files used to define configuration for managing | |
// multiple containers at the same time. | |
// Allows referencing an existing Compose files so that its abstractions as | |
// Services and Volumes will be included in the resulting development | |
// environment. |
Can we please pause and think about how this is actually going to work? Please see and continue discussion at #501 (comment) |
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Angel Misevski <amisevsk@redhat.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
What does this PR do?:
Changes for including Compose Component to reference a compose yaml file. Generated devworkspace CRDs and schemas for corresponding changes in v1alpha2 api.
I have create an example devfile in samples/devfiles/docker-compose-devfile.yaml
Which issue(s) this PR fixes:
#501
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: