Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated java models workflow #753

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sedovalx
Copy link

@sedovalx sedovalx commented Feb 2, 2022

What does this PR do?:

This PR adds a new workflow to generate, build, and publish java models. The maven publication targets the GitHub packages at the moment, the artifact name is io.devfile:api-model:2.2.0-alpha. I have altered the generate.sh so that it supports both typescript and java now. That potentially can break the typescript-models workflow, though I have run the workflow in my fork and it looked good for all steps before the actual yarn publication (the NPM_TOKEN is missing in my fork).

  • Documentation

Updated the README.md to reflect the fact that the generate.sh script can be used for both typescript and java.

  • Client Impact

Shouldn't impact existing clients.

How to test changes / Special notes to the reviewer:

I've updated the workflows, so they should be run to verify their correctness.

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sedovalx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benoitf
Copy link
Contributor

benoitf commented Feb 2, 2022

Thx, FYI you need to add SignedOff on the commits

@sedovalx
Copy link
Author

sedovalx commented Feb 2, 2022

Thanks, I will rebase the commits.

Also, can we change

    "attributes": {
      "description": "Map of implementation-dependant free-form YAML attributes.",
      "type": "object",
      "additionalProperties": true
    }

to

    "attributes": {
      "description": "Map of implementation-dependant free-form YAML attributes.",
      "type": "object",
      "additionalProperties": {
        "type": "object"
      }
    }

in the devfile.json for better types generation in java ?

Signed-off-by: Alexander.Sedov <alexander.sedov@jetbrains.com>
Signed-off-by: Alexander.Sedov <alexander.sedov@jetbrains.com>
@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2022

@sedovalx: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants