Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Nodejs CRUD devfile with outer-loop information #47

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sbose78
Copy link

@sbose78 sbose78 commented May 12, 2020

( PR has been created for contextual discussions )

What does this PR do?

Adds a new devfile sample with inner-loop and outer-loop details containing build and deploy guidance.

Source code used in the devfile:
https://github.com/sbose78/nodejs-rest-http-crud/tree/for-devfile

I haven't tested this yet. I've used existing API support, without introduction of anything new.
Inner-loop details copied from https://github.com/devfile/kubernetes-api/blob/master/devfile-support/samples/nodejs-stack.devfile.yaml

I will create follow-up issues for enhancing the devfile to support:

  • helm charts
  • pod-spec based deployment guidance.
  • kubernetes apiVersion & Kind based deployment guidance.
  • source-to-image and buildpacks based build guidance.

What issues does this PR fix or reference?

Is your PR tested? Consider putting some instruction how to test your changes

Not yet!

Docs PR

I haven't tested this yet. I've used existing support, without introduction of anything new. 
Inner-loop details copied from https://github.com/devfile/kubernetes-api/blob/master/devfile-support/samples/nodejs-stack.devfile.yaml

I will create follow-up issues for enhancing the devfile to support:

* helm charts
* pod-spec based deployment guidance.
* kubernetes apiVersion & Kind based deployment guidance.
* source-to-image and buildpacks based build guidance.
@sbose78 sbose78 changed the title Add a devfile with outer-loop information Add a Nodejs CRUD devfile with outer-loop information May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant