Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Compatibility to Angular universal #10

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

abelpuentes
Copy link

@abelpuentes abelpuentes commented Oct 13, 2020

PR Checklist

Verify that you did the following:

  • Opened an issue to track and discuss the problem you are trying to solve.
  • Submitted the changes using a new branch in your fork of this repo.
  • Added test for the changes and checked that code coverage didn't diminished if possible.
  • Docs were updated using jsdoc style comments when necessary.

Describe what you did

Used variable window based on PLATFORM_ID, to avoid issues in projects using Angular Universal.

Is this a breaking change?

  • Yes
  • No

Other information

@abelpuentes
Copy link
Author

@devconcept could you please check this pull request?

@abelpuentes
Copy link
Author

@devconcept do you have any feedback?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant