Additional Rootbeer overrides #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowandh
commented
Jan 24, 2017
rowandh
commented
- Adds additional public method overrides for RootBeer, which some app use directly instead of calling RootBeerNative.checkForRoot()
- Tested on my device against RootBeer Sample, passes all tests
- Remove tool-checker library hook as it cause crash.
- Add hook for RootBeerNative.checkForRoot() native method.
- Add hook for exec 'getprop' command.
- Update hook for SystemProperties.get("ro.build.selinux").
|
What's the impact of SELinux disabled (returning an empty string) vs forcing enabled (returning 1)? (I personally don't run my device rooted anymore) |
|
@hikaritenchi this I am not sure about. Perhaps the author of the original PR @prattpratt can answer |
|
@rowandh , @hikaritenchi I've disabled SELinux because rootbeer has corresponding check SELINUX FLAG ENABLED (EXPERIMENTAL). Otherwise (if return "1") this check fail and phone is detected as rooted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.