Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Json function and its unit test #92

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hariswb
Copy link

@hariswb hariswb commented Feb 22, 2022

Here is my first PR. The test might not be exhaustive but I think it's good for the start.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #92 (6af8e55) into main (419f932) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           67        68    +1     
  Lines          764       769    +5     
  Branches       338       338           
=========================================
+ Hits           764       769    +5     
Impacted Files Coverage Δ
src/lib/volder-types/json.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419f932...6af8e55. Read the comment docs.

@alguerocode
Copy link
Member

thank you. it will be merge in the next version

@alguerocode alguerocode self-assigned this Feb 23, 2022
@alguerocode alguerocode linked an issue Feb 23, 2022 that may be closed by this pull request
@alguerocode alguerocode self-requested a review February 23, 2022 10:37
@alguerocode alguerocode assigned hariswb and unassigned hariswb and alguerocode Feb 23, 2022
@alguerocode alguerocode requested a review from a team February 23, 2022 10:45
@alguerocode
Copy link
Member

alguerocode commented Feb 23, 2022

sorry you are forget the to Json function import in index.js

@hariswb
Copy link
Author

hariswb commented Feb 23, 2022

my bad. i'll add that too

@hariswb
Copy link
Author

hariswb commented Mar 1, 2022

@alguerocode I've just added the function in the index.js

@alguerocode
Copy link
Member

alguerocode commented Mar 2, 2022

@alguerocode I've just added the function in the index.js

your are doing well bro

i will add in contributers section soon

I have a devSupporters team in discord, if you want join click in discord badge in readme.md file, there we will discuss the next version of volder 3.0.0

note: first send a message to know you. you will find me as the same name alguerocode
thank you

@hariswb
Copy link
Author

hariswb commented Mar 2, 2022

thanks. i'll check out the discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON function: is new volder type
2 participants