Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement API and CLI for set resource quota #9327

Open
wants to merge 1 commit into
base: amanda/addAutoCreateNamespace
Choose a base branch
from

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented May 7, 2024

chore: implement set resource quota commands and API endpoints

Ticket

DET-10223

Description

Create CLI command and API endpoints to optionally set resource quota during workspace creation, or to set quota for an already existing workspace.

Rebased onto #9328

Test Plan

  • Start up a multiRM cluster using two kubernetes resource managers with names c1 and c2 respectively.
  • Create a workspace by running det w create <worskpace-name>
  • Create a namespace in your Kubernetes cluster c1 by running kubectl create namespace ns1
  • Bind the workspace to a namespace from cluster c1 by running det w bindings add <worskpace-name> c1 --namespace ns1
  • Run det w bindings set quota <workspace-name> 10
  • Run kubectl get quota and verify that the quota returned from the above CLI command is listed with the correct request limit of 10

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented May 7, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit ccb4e41
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663e8038cb4ae000082c4f34
😎 Deploy Preview https://deploy-preview-9327--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amandavialva01 amandavialva01 changed the title Amanda/set resource quota chore: implement Set Resource Quota May 7, 2024
@amandavialva01 amandavialva01 changed the title chore: implement Set Resource Quota feat: implement API and CLI for set resource quota May 7, 2024
@amandavialva01 amandavialva01 force-pushed the amanda/setResourceQuota branch 3 times, most recently from df0ebd2 to ccb4e41 Compare May 10, 2024 20:14
@amandavialva01 amandavialva01 changed the base branch from main to amanda/addAutoCreateNamespace May 13, 2024 18:11
@amandavialva01 amandavialva01 force-pushed the amanda/addAutoCreateNamespace branch 2 times, most recently from d073e49 to 77c9422 Compare May 14, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant