fix: remove learning curve trials where metric values exceed 100000

determined-ai · Jan 15, 2021 · 609167f · 609167f
1 parent 9307710
commit 609167f
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/webui/react/src/pages/ExperimentDetails/ExperimentVisualization/LearningCurve.tsx b/webui/react/src/pages/ExperimentDetails/ExperimentVisualization/LearningCurve.tsx
@@ -45,7 +45,8 @@ interface TrialHParams {
 
 const DEFAULT_MAX_TRIALS = 100;
 const MAX_DATAPOINTS = 5000;
-const TOP_TRIALS_OPTIONS = [ 1, 10, 20, 50, 100, 200, 500 ];
+const MAX_ALLOWED_METRIC_VALUE = 100000;
+const TOP_TRIALS_OPTIONS = [ 1, 10, 20, 50, 100 ];
 
 const LearningCurve: React.FC<Props> = ({
   experiment,
@@ -174,6 +175,7 @@ const LearningCurve: React.FC<Props> = ({
     const trialHpMap: Record<number, TrialHParams> = {};
     const batchesMap: Record<number, number> = {};
     const metricsMap: Record<number, Record<number, number>> = {};
+    const filterTrialMap: Record<number, boolean> = {};
 
     consumeStream<V1TrialsSampleResponse>(
       detApi.StreamingInternal.determinedTrialsSample(
@@ -198,8 +200,6 @@ const LearningCurve: React.FC<Props> = ({
 
         (event.promotedTrials || []).forEach(trialId => trialIdsMap[trialId] = trialId);
         (event.demotedTrials || []).forEach(trialId => delete trialIdsMap[trialId]);
-        const newTrialIds = Object.values(trialIdsMap);
-        setTrialIds(newTrialIds);
 
         (event.trials || []).forEach(trial => {
           const id = trial.trialId;
@@ -216,11 +216,13 @@ const LearningCurve: React.FC<Props> = ({
 
           trialDataMap[id] = trialDataMap[id] || [];
           metricsMap[id] = metricsMap[id] || {};
+          filterTrialMap[id] = filterTrialMap[id] || false;
 
           trial.data.forEach(datapoint => {
             batchesMap[datapoint.batches] = datapoint.batches;
             metricsMap[id][datapoint.batches] = datapoint.value;
             trialHpMap[id].metric = datapoint.value;
+            if (datapoint.value > MAX_ALLOWED_METRIC_VALUE) filterTrialMap[id] = true;
           });
         });
 
@@ -233,6 +235,9 @@ const LearningCurve: React.FC<Props> = ({
         const newBatches = Object.values(batchesMap);
         setBatches(newBatches);
 
+        const newTrialIds = Object.values(trialIdsMap).filter(trialId => !filterTrialMap[trialId]);
+        setTrialIds(newTrialIds);
+
         const newChartData = newTrialIds.map(trialId => newBatches.map(batch => {
           const value = metricsMap[trialId][batch];
           return value != null ? value : null;