Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't duplicate constants #7242

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Don't duplicate constants #7242

merged 1 commit into from
Apr 28, 2024

Conversation

BraisGabin
Copy link
Member

We had DETEKT_OUTPUT_REPORT_BASE_PATH_KEY on :detekt-api and detekt-core. core can use the value in api to avoid disalignments.

#7241 will obsolete this PR but meanwhile it will help to find the usages too.

@detekt-ci
Copy link
Collaborator

detekt-ci commented Apr 28, 2024

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against ef767dc

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (0cab28d) to head (ef767dc).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7242   +/-   ##
=========================================
  Coverage     84.70%   84.70%           
  Complexity     3992     3992           
=========================================
  Files           578      578           
  Lines         12164    12164           
  Branches       2495     2495           
=========================================
  Hits          10303    10303           
  Misses          627      627           
  Partials       1234     1234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3flex 3flex merged commit db36aac into main Apr 28, 2024
21 checks passed
@3flex 3flex deleted the dont-repeat-constants branch April 28, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants