Remove FilePath #7235
Merged
Remove FilePath #7235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3flex
added
the
breaking change
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7235 +/- ##
============================================
+ Coverage 84.71% 84.77% +0.05%
Complexity 3993 3993
============================================
Files 578 578
Lines 12163 12138 -25
Branches 2494 2484 -10
============================================
- Hits 10304 10290 -14
+ Misses 626 624 -2
+ Partials 1233 1224 -9 ☔ View full report in Codecov by Sentry. |
This was referenced Apr 28, 2024
BraisGabin
reviewed
Apr 29, 2024
detekt-report-md/src/main/kotlin/io/github/detekt/report/md/MdOutputReport.kt
Outdated
Show resolved
Hide resolved
| @@ -52,7 +52,7 @@ class SarifOutputReportSpec { | |||
| .render(result) | |||
|
|
|||
| val expectedReport = readResourceContent("vanilla.sarif.json") | |||
| .replace("<PREFIX>", Path("/").absolute().toUri().toString()) | |||
| .replace("<PREFIX>", Path(System.getProperty("user.dir")).toUri().toString()) | |||
There was a problem hiding this comment.
Probably this change is needed for the issue that I was talking before.
detekt-formatting/src/test/kotlin/io/gitlab/arturbosch/detekt/formatting/FormattingRuleSpec.kt
Fixed
Show fixed
Hide fixed
.../test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/FileBasedIssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/CodeSmellSpec.kt
Fixed
Show fixed
Hide fixed
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/CodeSmellSpec.kt
Fixed
Show fixed
Hide fixed
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/CodeSmellSpec.kt
Fixed
Show fixed
Hide fixed
.../test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/FileBasedIssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
.../test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/FileBasedIssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
detekt-formatting/src/test/kotlin/io/gitlab/arturbosch/detekt/formatting/FormattingRuleSpec.kt
Fixed
Show fixed
Hide fixed
detekt-formatting/src/test/kotlin/io/gitlab/arturbosch/detekt/formatting/FormattingRuleSpec.kt
Fixed
Show fixed
Hide fixed
This was referenced May 3, 2024
BraisGabin
reviewed
May 3, 2024
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/Location.kt
Outdated
Show resolved
Hide resolved
BraisGabin
approved these changes
May 3, 2024
This was referenced May 3, 2024
|
LGTM. It's strange the usages of user.dir on tests but that's clearly not important and you have a lot of PRs waiting for this. |
They weren't really needed, I've stripped them out. Thanks for your time on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.