Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TopLevelPropertyNaming also detecting extension property name #7212

Merged
merged 1 commit into from May 1, 2024

Conversation

psuzn
Copy link
Contributor

@psuzn psuzn commented Apr 22, 2024

fixes: #7193

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (d4f3f99) to head (b9c360e).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7212   +/-   ##
=========================================
  Coverage     84.70%   84.70%           
- Complexity     3983     3984    +1     
=========================================
  Files           578      578           
  Lines         12151    12151           
  Branches       2495     2495           
=========================================
  Hits          10292    10292           
  Misses          625      625           
  Partials       1234     1234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psuzn psuzn force-pushed the top-level-property-naming-issue branch from 751e790 to b9c360e Compare April 22, 2024 13:17
@psuzn psuzn marked this pull request as ready for review April 22, 2024 13:37
@chao2zhang chao2zhang merged commit acc8e74 into detekt:main May 1, 2024
21 checks passed
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against b9c360e

@3flex 3flex added this to the 2.0.0 milestone May 1, 2024
@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pick request Marker for PRs that should be ported to the 1.0 release branch rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positive: TopLevelPropertyNaming applying to extension properties
5 participants