Merge pull request #137 from destinygg/banned-word

Remove invalid argument from some calls to `makeMute`
destinygg · Jun 19, 2023 · 86a3c52 · 86a3c52
2 parents 4498a3f + 01488e2
commit 86a3c52
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/lib/commands/implementations/mute.js b/lib/commands/implementations/mute.js
@@ -22,7 +22,6 @@ function mute(input, services) {
         parsedDuration,
         `Muting: ${userToPunish} for ${formatDuration(moment.duration(parsedDuration, 'seconds'))}`,
       ),
-      true,
     );
   });
   return new CommandOutput(null, null);

diff --git a/lib/commands/implementations/mutelinks.js b/lib/commands/implementations/mutelinks.js
@@ -63,7 +63,6 @@ function mutelinks(defaultPunishmentDuration) {
           muteDuration,
           `${data.user} muted for ${formattedDuration} for posting a link while link muting is on.`,
         ),
-        true,
       );
     });
     const displayState = state === 'all' ? 'on for all links' : state;

diff --git a/lib/services/punishment-read-write-stream.js b/lib/services/punishment-read-write-stream.js
@@ -93,6 +93,10 @@ class PunishmentReadWriteStream extends Transform {
     this.push(punished);
   }
 
+  /**
+   * @param {Object} punished
+   * @param {boolean} punished.isBannedWord `true` if this mute was automatically issued as a result of the user typing a banned word
+   */
   handleMute(punished) {
     getReporter().incrementCounter(METRIC_NAMES.MUTES_GIVEN, 1);
     let muteDuration = null;
@@ -124,11 +128,7 @@ class PunishmentReadWriteStream extends Transform {
   }
 
   sendMute(reason, muteDuration, type, user) {
-    const clampedMutedDuration = _.clamp(
-      muteDuration,
-      0,
-      this.punishmentCache.maxMuteSeconds,
-    );
+    const clampedMutedDuration = _.clamp(muteDuration, 0, this.punishmentCache.maxMuteSeconds);
     this.push({
       user,
       duration: clampedMutedDuration,