Fix select all keyboard shortcut in lists on Windows #7767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niik
added
the
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #7759
Description
When a user invokes the
Select Allmenu item under theEditmenu Desktop dispatches a custom DOM event calledselect-allwhich components can (currently onlyListimplements this) elect to handle. #7759 pointed out thatCtrl+Adoesn't work on Windows and it turns out that this is a known problem where Chromium will steal a few select keyboard shortcuts (Ctrl+A, Ctrl+Z, etc) in such a way that Electron doesn't have a chance to match them to menu item accelerators.This PR adds a special case for Windows in lists so that we handle the DOM event for
Ctrl+Aand treat it the same way as we would theselect-allcustom DOM event.Release notes
Notes: [Fixed] Ctrl+A keyboard shortcut didn't select all changed files on Windows.