Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-mechanic improvements #175

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

fdoflorenzano
Copy link
Contributor

A bunch of pending improvements for create-mechanic!

  • The most important that has been pending, this tweaks how design function templates and examples are managed, so that it also supports copying functions with custom inputs! The directory structure was changed to make this easier, so you'll see a lot of moved files. Each design function base has a directory with a function/ folder (design function source code), a dependencies.json file (with a list of dependencies for the DF), and may have an inputs/ folder with any custom inputs the DF uses.
  • The previous change allows us to finally add the Adaptive Grid example @munusshih made a while ago! It used a custom input, and it will soon be able to replicate it for mechanic users across! Thanks again for this @munusshih! The other examples you made will be added as soon as possible too.
  • Now create will also add an .gitignore file to a new project. As well as try to initialize a new git repository. This is a little improvemene that will make creating DFs and posting to GitHub more easy and quick.
  • Added a little detail for the installing section. The cli asks users if they want to install dependencies, and now it will also list which dependencies are being installed.
  • Added some line breaks across different sections to make the CLI output more readable.

Screenshot 2023-05-05 at 13 15 00

Screenshot 2023-05-05 at 13 15 18

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for dsi-logo-maker ready!

Name Link
🔨 Latest commit 3c99e16
🔍 Latest deploy log https://app.netlify.com/sites/dsi-logo-maker/deploys/64961be57599d500089322ce
😎 Deploy Preview https://deploy-preview-175--dsi-logo-maker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably replaced by an open source font.

Hate to recommend poppins, but I think we can get away visually with replacing it with Poppins 😊

Other alternatives could be

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yah tots agree. I remember I was only using Futura, because that was what was used on the original logo. But we should definitely replace it by an open source font.

Screenshot 2023-05-10 at 2 48 09 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that this took so long for me to get back to! But I finally did!

Great catch @lucasdinonolte! Funnily enough, the one example selected to add here didn't actually use Futura. So for now it's enough to just remove the file and unused declaration.

Tho in the near future where we do add the other examples, we would need to replace Futura. @munusshih Do you have any font replacement preference for it? Lucas linked to some nice alternatives.

@fdoflorenzano
Copy link
Contributor Author

I also went ahead and cleaned up some other unused CSS declarations, and formatted some files that weren't before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants