Adding Decision Document around Timeline #158
Conversation
✅ Deploy Preview for dsi-logo-maker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
I like it! I think it's simple and nice. One thing I think we need to consider is play/stop functionality and how this interacts with the timeline. Right now the animation just runs from the beginning whenever you update an input value. But if the timeline is set, I guess it needs to just show that frame? And what decides whether it's playing or not? I think the timeline functionality should solve this too, perhaps with some sort of autoplay feature or actual controls in the timeline.
| The timeline is a development feature only. When building your design tool for | ||
| deployment it is not exported. |
There was a problem hiding this comment.
I'm not entirely sure about this. I can easily see users wanting to preview certain frames of their exports based on their input settings.
There was a problem hiding this comment.
Ok, what would that mean for the export then? Would you be able to export only the range of the timeline then? Does setting the timeline to one frame allow you to export a single frame then?
There was a problem hiding this comment.
I would argue that the setting of the timeline has no affect on the export. The export exports the whole thing no matter the setting on the timeline. This is also how it works in After Effects. You can zoom, but an export is the whole thing.
There was a problem hiding this comment.
Same here! I understood Rune's initial comment about the deployment of the tool. In a dev or prod scenario the timeline could be useful.
There was a problem hiding this comment.
Looking good! I left a comment regarding the min input, and I agree with @runemadsen about the pause and play functionality. I do think it's weird to have inconsistent autoplay depending on the timeline.
I'm thinking: timeline has the play/pause and allows it to play from any starting point thanks to the range, and no timeline just always auto-plays.
| By default the timeline renders with two additional number inputs for the min | ||
| frame number and the max frame number. The timeline scrubber interpolates | ||
| between these two values. This makes sure a developer can zoom in and zoom out | ||
| of the animation area they need. |
There was a problem hiding this comment.
Why should there be a min input and no setting to hardcode it? Is there a situation really where we need a min frame? isn't it always 0? Removing it also would help with the confusion of range export.
There was a problem hiding this comment.
Using min and max inputs allows a user to zoom to specifc ranges of frames if they want to.
WIth the hardcoded value it is assumed a user will always want the entire animation as the range of the timeline (thus 0 is implied as min value in that case).
There was a problem hiding this comment.
Interesting. I didn't get that implication from the setting of the timelineMaxFrames setting. Maybe it's a naming thing.
| The timeline is a development feature only. When building your design tool for | ||
| deployment it is not exported. |
I gave it a first pass to write down the results of our timeline brainstorm from last week.