Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add data model section #93

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Add data model section #93

wants to merge 1 commit into from

Conversation

c1rrus
Copy link
Member

@c1rrus c1rrus commented Jan 8, 2022

This is a WIP proposal to add some more detail to our spec about the data model that it describes.

@netlify
Copy link

netlify bot commented Jan 8, 2022

✔️ Deploy Preview for dtcg-tr ready!

🔨 Explore the source changes: 34af4dd

🔍 Inspect the deploy log: https://app.netlify.com/sites/dtcg-tr/deploys/61d8de67b1a884000873a4d9

😎 Browse the preview: https://deploy-preview-93--dtcg-tr.netlify.app/format


<figure>

![Diagram of a file on one side and a group and desing token tree on the other. An arrow pointing from the file to the data structure is labelled "parse". Another arrow pointing in the opposite direction is labelled "serialize".](./parse-serialize.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "desing"

@kevinmpowell
Copy link
Contributor

@c1rrus I like this addition. It's a nice sensitizing overview.

@c1rrus
Copy link
Member Author

c1rrus commented Jan 25, 2022

@c1rrus I like this addition. It's a nice sensitizing overview.

Thanks @kevinmpowell! There's still more I want to add to this section, but good to know that at least one other person agrees that this could be a useful addition to the spec! ^_^

FYI, I've decided to pause work on this PR until some of the ongoing discussions in other issues & PRs have concluded as I think they may influence or change the data model slightly.

@c1rrus c1rrus added the Do not merge Add this label to a PR to prevent it from accidentally being merged. label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not merge Add this label to a PR to prevent it from accidentally being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants