refactor flags & add missing flag base types #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Flag types int8, int16, int32, uint8, uint16, uint32, float32.
The PR also streamlines and simplifies the whole flag parsing process. IMO, this makes the code easier to read and requires only 1 line now for each of the flag types to be registered in the Flags.
There is also just one type that represents the internal flag now (
flagItem), where before this was splitted into the item and two funcs arcoss 3 slices.The change is backwards compatible, so flags can still be given in the following two forms:
cmd --flag valuecmd --flag=valuecmd --flagfor bool flagscmd --flag="multi word stuff"leads to justmulti word stuffbeing the value, for string flags.These rules have now also been added to the README