fix issues #230 & #233 #238
Conversation
…ons and aws-sdk dependency version)
…ct its dependencies)
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
===========================================
+ Coverage 67.31% 67.41% +0.1%
- Complexity 656 657 +1
===========================================
Files 83 83
Lines 2227 2222 -5
Branches 392 392
===========================================
- Hits 1499 1498 -1
+ Misses 549 547 -2
+ Partials 179 177 -2
Continue to review full report at Codecov.
|
…re registering its factory)
|
Wouldn't this break the idea of IoC? Effectively you are saying you are going to provide a singular bean per the configuration of the other two objects in only one way. How do I override the DynamoDBMapper if I want to? Not saying this isn't a valid fix for now, just some thoughts on how we could improve in the future. |
|
Also I believe that whole interface in use for the Mapper is deprecated. Probably fixed in aws-java-sdk-v2 that is whole different can of worms. Just curious if there is a better way to do this? |
|
Also, does this have to be synchronized? Separation of concerns would say that it should be left up to Spring to handle bean creation and its thread safety. Also, after going through some history it looks like this has been this way for a bit. Maybe a candidate for a refactor. |
|
Any updates here? |
|
Any updates here? Who can acccept this PR? We're blocked and need this fix! Maybe @derjust |
|
Push. Any movement here? @derjust @tiagocpeixoto |
|
Push. Issue still persists. |
|
@tiagocpeixoto may you please resolve the conflicting file? Otherwise i'll make a fork of your repo and do it myself, but need then to make a new PR. |
|
Sure, I´ll do it in the next few days. |
…nfigExtension conflicts)
|
I can't resolve all conflicts at the risk of bugs not being solved. Any suggestions? |
|
Applying the final touches to |
|
Hi The latest 5.1.1-SNAPSHOT broke our build with the rather mysterious stacktrace below which was tracked down to this. Using
|
|
Indeed, i can confirm that the latest build number 9 with version: 5.1.1-20190622.045831-9 our error in CICD pipeline is So like @allantodd stated, the previous build 5.1.1-20190310.225515-8 works |
|
@shexbeer @allantodd That is the offending file. |
|
@boostchicken Any Chance to get this integrated into your fork? |
|
@tobiashochguertel it should be fixed. |
Bumps [hibernate-validator](https://github.com/hibernate/hibernate-validator) from 6.0.9.Final to 6.1.0.Final. - [Release notes](https://github.com/hibernate/hibernate-validator/releases) - [Changelog](https://github.com/hibernate/hibernate-validator/blob/master/changelog.txt) - [Commits](hibernate/hibernate-validator@6.0.9.Final...6.1.0.Final) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](junit-team/junit4@r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>
…-4.13.1 Bump junit from 4.12 to 4.13.1
…te.validator-hibernate-validator-6.1.0.Final Bump hibernate-validator from 6.0.9.Final to 6.1.0.Final
|
Should I close this PR? Does it still make sense? |
Issue #230: I changed
DynamoDBMapperFactoryto use@Autowiredto injectAmazonDynamoDBandDynamoDBMapperConfigbeans.Issue #233: checks if dynamoDBMapperConfigRef is set before registering its factory.
Are these approaches correct?