Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot fix that marks uswds components as false, fixes for these compone… #28643

Merged
merged 12 commits into from Mar 20, 2024
Merged

Hot fix that marks uswds components as false, fixes for these compone… #28643

merged 12 commits into from Mar 20, 2024

Conversation

vsaleem
Copy link
Contributor

@vsaleem vsaleem commented Mar 19, 2024 •
edited

Summary

Related issue(s)

[MHV-55186] V1 to V3 USWDS Web Components Update

[Additional fixes Pull Request] Update all V1 components to V3 web components on SM MHV

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/HOTFIX--V1-to-V3--set-uswds-to-false-mhv/main March 19, 2024 17:09 Inactive
KolbyVA
KolbyVA previously approved these changes Mar 19, 2024
View reviewed changes
oleksii-morgun
oleksii-morgun previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@oleksii-morgun oleksii-morgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super 👍🏻

KyleCardwell
KyleCardwell previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@KyleCardwell KyleCardwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@vsaleem vsaleem marked this pull request as ready for review March 19, 2024 19:08
@vsaleem vsaleem requested review from a team as code owners March 19, 2024 19:08
@va-vfs-bot va-vfs-bot temporarily deployed to master/HOTFIX--V1-to-V3--set-uswds-to-false-mhv/main March 19, 2024 20:35 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/HOTFIX--V1-to-V3--set-uswds-to-false-mhv/main March 19, 2024 23:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/HOTFIX--V1-to-V3--set-uswds-to-false-mhv/main March 20, 2024 00:07 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/HOTFIX--V1-to-V3--set-uswds-to-false-mhv/main March 20, 2024 15:10 Inactive
jamigibbs
jamigibbs previously approved these changes Mar 20, 2024
View reviewed changes
@va-vfs-bot va-vfs-bot temporarily deployed to master/HOTFIX--V1-to-V3--set-uswds-to-false-mhv/main March 20, 2024 19:02 Inactive
KyleCardwell
KyleCardwell approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@KyleCardwell KyleCardwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

oleksii-morgun
oleksii-morgun approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@oleksii-morgun oleksii-morgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving

@vsaleem vsaleem merged commit 0f3d50b into main Mar 20, 2024
82 checks passed
@vsaleem vsaleem deleted the HOTFIX--V1-to-V3--set-uswds-to-false-mhv branch March 20, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleCardwell KyleCardwell KyleCardwell approved these changes

@oleksii-morgun oleksii-morgun oleksii-morgun approved these changes

@jamigibbs jamigibbs jamigibbs left review comments

@KolbyVA KolbyVA KolbyVA left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vsaleem @jamigibbs @KyleCardwell @oleksii-morgun @KolbyVA @va-vfs-bot @fazilqa