Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uswds from mhv-landing-page components after v3 update #28534

Merged
merged 4 commits into from Mar 19, 2024

Conversation

jzucadi
Copy link
Contributor

@jzucadi jzucadi commented Mar 13, 2024

The design team will be upgrading all web-component to their V3 versions. This PR updates the current va components to their v3 versions.

The following files were updated:

Screenshot 2024-02-29 at 4 38 03 PM

Related issue(s)

Slack message from #vfs-change-announcements
Screenshot 2024-01-31 at 10 41 09 AM

Tasks

  • Manually remove uswds to all web-component instances in mhv-landing-page.

Acceptance criteria

  • Update every component to not have USWDS prop as v3 update will set this true by default

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Copy link
Contributor

@micahchiang micahchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for now. There's nothing wrong with this PR, we haven't been able to merge our design system PR into vets website yet, so I don't want you to merge this early and then be left waiting.

@va-vfs-bot va-vfs-bot temporarily deployed to master/77816-Remove-USWDS-from-MHV-landing-page/main March 13, 2024 21:21 Inactive
@jzucadi jzucadi merged commit efb684a into main Mar 19, 2024
77 checks passed
@jzucadi jzucadi deleted the 77816-Remove-USWDS-from-MHV-landing-page branch March 19, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants