Breadcrumbs v1 part five set uswds to false #28515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
it-harrison
previously approved these changes
Mar 12, 2024
va-vfs-bot
temporarily deployed
to
master/mc-breadcrumbs-v1-part-five/main
va-vfs-bot
temporarily deployed
to
master/mc-breadcrumbs-v1-part-five/main
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
va-vfs-bot
temporarily deployed
to
master/mc-breadcrumbs-v1-part-five/main
va-vfs-bot
temporarily deployed
to
master/mc-breadcrumbs-v1-part-five/main
va-vfs-bot
temporarily deployed
to
master/mc-breadcrumbs-v1-part-five/main
va-vfs-bot
temporarily deployed
to
master/mc-breadcrumbs-v1-part-five/main
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
va-vfs-bot
temporarily deployed
to
master/mc-breadcrumbs-v1-part-five/main
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
va-vfs-bot
temporarily deployed
to
master/mc-breadcrumbs-v1-part-five/main
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
va-vfs-bot
temporarily deployed
to
master/mc-breadcrumbs-v1-part-five/main
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
va-vfs-bot
temporarily deployed
to
master/mc-breadcrumbs-v1-part-five/main
it-harrison
previously approved these changes
Mar 13, 2024
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
it-harrison
approved these changes
Mar 13, 2024
pjhill
pushed a commit
that referenced
this pull request
Mar 14, 2024
* set uswds to false Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * update debt letters to v3 Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * remove trailing slash Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * set failOnStatusCode to false Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * retry so hard and got so far... Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * but in the end it didnt even matter Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * skip tests that will eventually be removed Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
wullaski
pushed a commit
that referenced
this pull request
Mar 14, 2024
* set uswds to false Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * update debt letters to v3 Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * remove trailing slash Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * set failOnStatusCode to false Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * retry so hard and got so far... Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * but in the end it didnt even matter Signed-off-by: Micah Chiang <micahkchiang@gmail.com> * skip tests that will eventually be removed Signed-off-by: Micah Chiang <micahkchiang@gmail.com> --------- Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breadcrumbs v1 and v3 have some differences in how they are composed. Because of this, all instances where breadcrumb web components have not already been set with uswds="true" will be set to false for the time being.