Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumbs v1 part one set uswds to false #28511

Merged
merged 1 commit into from Mar 12, 2024
Merged

Breadcrumbs v1 part one set uswds to false #28511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/applications/ask-va/components/BreadCrumbs.jsx
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ const BreadCrumbs = ({ currentLocation }) => {
const breadcrumbLinks = breadcrumbsDictionary[adjustedLocation];

return (
<va-breadcrumbs label="Breadcrumbs">
<va-breadcrumbs uswds="false" label="Breadcrumbs">
{breadcrumbLinks.map(link => (
<a href={link.href} key={link.key}>
{link.title}
Expand Down
2 changes: 1 addition & 1 deletion src/applications/education-letters/components/Layout.jsx
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@

return (
<>
<va-breadcrumbs>
<va-breadcrumbs uswds="false">
<a href="/">Home</a>
<a href="/education/">Education and training</a>
{renderBreadCrumbs()}
Expand All @@ -30,8 +30,8 @@

Layout.propTypes = {
clsName: PropTypes.string,
children: PropTypes.object,

Check warning on line 33 in src/applications/education-letters/components/Layout.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/education-letters/components/Layout.jsx:33:3:Prop types declarations should be sorted alphabetically
breadCrumbs: PropTypes.object,

Check warning on line 34 in src/applications/education-letters/components/Layout.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/education-letters/components/Layout.jsx:34:3:Prop types declarations should be sorted alphabetically
};

export default Layout;
2 changes: 1 addition & 1 deletion src/applications/enrollment-verification/components/EnrollmentVerificationBreadcrumbs.jsx
View file
Open in desktop
Expand Up @@ -52,5 +52,5 @@ export default function EnrollmentVerificationBreadcrumbs() {
);
}

return <va-breadcrumbs>{breadcrumbs}</va-breadcrumbs>;
return <va-breadcrumbs uswds="false">{breadcrumbs}</va-breadcrumbs>;
}
2 changes: 1 addition & 1 deletion src/applications/fry-dea/containers/FryDeaApp.jsx
View file
Open in desktop
Expand Up @@ -2,12 +2,12 @@
import { connect } from 'react-redux';
import PropTypes from 'prop-types';

import FEATURE_FLAG_NAMES from 'platform/utilities/feature-toggles/featureFlagNames';

Check warning on line 5 in src/applications/fry-dea/containers/FryDeaApp.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/fry-dea/containers/FryDeaApp.jsx:5:1:Importing from platform via platform/utilities is deprecated. Import from @department-of-veterans-affairs/platform-utilities instead or check babel.config.json for an alias to the import.

import RoutedSavableApp from 'platform/forms/save-in-progress/RoutedSavableApp';

Check warning on line 7 in src/applications/fry-dea/containers/FryDeaApp.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/fry-dea/containers/FryDeaApp.jsx:7:1:Importing from platform via platform/forms is deprecated. Import from @department-of-veterans-affairs/platform-forms instead or check babel.config.json for an alias to the import.

import { setData } from 'platform/forms-system/src/js/actions';

Check warning on line 9 in src/applications/fry-dea/containers/FryDeaApp.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/fry-dea/containers/FryDeaApp.jsx:9:1:Importing from platform via platform/forms-system is deprecated. Import from @department-of-veterans-affairs/platform-forms-system instead or check babel.config.json for an alias to the import.
import { toggleValues } from 'platform/site-wide/feature-toggles/selectors';

Check warning on line 10 in src/applications/fry-dea/containers/FryDeaApp.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/fry-dea/containers/FryDeaApp.jsx:10:1:Importing from platform via platform/site-wide is deprecated. Import from @department-of-veterans-affairs/platform-site-wide instead or check babel.config.json for an alias to the import.
import formConfig from '../config/form';
import { fetchVeterans } from '../actions';
import { VETERANS_TYPE } from '../constants';
Expand All @@ -19,14 +19,14 @@
location,
setFormData,
showUpdatedFryDeaApp,
user,

Check warning on line 22 in src/applications/fry-dea/containers/FryDeaApp.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/fry-dea/containers/FryDeaApp.jsx:22:3:'user' is missing in props validation
veterans,
}) {
const [fetchedVeterans, setFetchedVeterans] = useState(false);

useEffect(
() => {
if (!user.login.currentlyLoggedIn) {

Check warning on line 29 in src/applications/fry-dea/containers/FryDeaApp.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/fry-dea/containers/FryDeaApp.jsx:29:17:'user.login' is missing in props validation

Check warning on line 29 in src/applications/fry-dea/containers/FryDeaApp.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/fry-dea/containers/FryDeaApp.jsx:29:23:'user.login.currentlyLoggedIn' is missing in props validation
return;
}

Expand All @@ -53,14 +53,14 @@
location.pathname,
setFormData,
showUpdatedFryDeaApp,
user.login.currentlyLoggedIn,

Check warning on line 56 in src/applications/fry-dea/containers/FryDeaApp.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/fry-dea/containers/FryDeaApp.jsx:56:12:'user.login' is missing in props validation
veterans,
],
);

return (
<>
<va-breadcrumbs>
<va-breadcrumbs uswds="false">
<a href="/">Home</a>
<a href="/education">Education and training</a>
<a href="/fry-dea">
Expand Down