New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MHV-55186] Update all V1 components to V3 web components on SM MHV #28504
Closed
Closed
Changes from 6 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
0b7b250
[MHV-55186] Update Message landing components to V3
vsaleem 8af53af
Merge branch 'main' into 55186-Update-all-V1-components-to-V6-on-sm-mhv
vsaleem 97c5991
[MHV-55186] Updated modals, buttons, and dropdowns with uswds
vsaleem 91fcdd4
Merge branch 'main' into 55186-Update-all-V1-components-to-V6-on-sm-mhv
vsaleem f3e129c
[MHV-55186] Update SM va-components to uswds
vsaleem f8c6800
Merge branch 'main' into 55186-Update-all-V1-components-to-V6-on-sm-mhv
vsaleem e5f1783
upd: locators and fix failed tests
fazilqa 2d42ef9
upd: locators and fix failed tests
fazilqa e3c4798
upd: locators and fix failed tests
fazilqa 1870986
upd: locators and fix failed tests
fazilqa b4f6b5c
upd: locators and fix failed tests
fazilqa 7843bf9
upd: locators and fix failed tests
fazilqa 20d9637
[MHV-55186] cleanup; added charcount to sm subject input
vsaleem d12f76e
Merge branch '55186-Update-all-V1-components-to-V6-on-sm-mhv' of http…
vsaleem ce2fb22
Merge branch 'main' into 55186-Update-all-V1-components-to-V6-on-sm-mhv
vsaleem 5dcbea7
upd: locators and fix failed tests
fazilqa 7340055
upd: temporary skip failed test
fazilqa 2f846eb
upd: unskip the test
fazilqa d219eab
[MHV-55186] Hotfix to update sm V3 components for release
vsaleem dc4ddda
Merge branch 'main' into 55186-Update-all-V1-components-to-V6-on-sm-mhv
vsaleem 44954e5
attempt to resolve linting errors
vsaleem d4fb5cc
Merge branch 'main' into 55186-Update-all-V1-components-to-V6-on-sm-mhv
vsaleem bc3180e
2nd attempt to fix linting errs
vsaleem c558765
Merge branch 'main' into 55186-Update-all-V1-components-to-V6-on-sm-mhv
vsaleem 6b4764e
cleanup, added null safety
vsaleem 797fd7d
fix eslint
vsaleem 23d22da
Merge branch 'main' into 55186-Update-all-V1-components-to-V6-on-sm-mhv
vsaleem fe2c719
[MHV-55186] Added margins between mobile view buttons
vsaleem 6f154d1
cleanup eslint, set dropdown uswds to false
vsaleem 4f4f320
upd: update selectors & refactor
fazilqa d87023b
upd: update assertions
fazilqa 52e45a4
upd: fix failed test
fazilqa 1ef0dd4
upd: remove skip
fazilqa 9fddf13
[MHV-55186] Removing uswds true tags, no longer needed
vsaleem 0efeccb
Merge branch '55186-Update-all-V1-components-to-V6-on-sm-mhv' of http…
vsaleem 07fc403
Merge branch 'main' into 55186-Update-all-V1-components-to-V6-on-sm-mhv
vsaleem 82d7c10
cleanup
vsaleem 9a08371
cleanup, format components with eslint
vsaleem b886ef5
cleanup with eslint format
vsaleem e573e35
cleanup using eslint
vsaleem fdbb3a6
cleanup files not apart of sm
vsaleem 7320089
cleanup non-sm file
vsaleem File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -139,6 +139,7 @@ const FileInput = props => { | |
/> | ||
|
||
<va-button | ||
uswds | ||
onClick={useFileInput} | ||
secondary | ||
text={ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this
h3
suggested by a11y? trying to see the rationale behind replacingp
with heading tag