Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-55122: Follow up fix of a link #28319

Merged
merged 1 commit into from Mar 4, 2024
Merged

Conversation

vmenshutin-bylight
Copy link
Contributor

@vmenshutin-bylight vmenshutin-bylight commented Mar 4, 2024

This is a follow up of #28255

Fixed URL due to Link cannot handle absolute path.

Related issue(s)

https://jira.devops.va.gov/browse/MHV-55122

image

Testing done

  • Manual testing

What areas of the site does it impact?

/my-health/medications/

Acceptance criteria

AC1: New content for the header on the landing page, remove the informational body text
AC2: Add action link to begin the new pages/flow
AC3: Update content, changed colors to blue
AC4: For fillable/refillable meds on the details page the button should change from a button to a primary green action link that takes them to new refill page.

Sketch Link:Medications – Figma

Screenshots

image image

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@vmenshutin-bylight vmenshutin-bylight merged commit c0d22fc into main Mar 4, 2024
87 of 88 checks passed
@vmenshutin-bylight vmenshutin-bylight deleted the mhv-55122-link-fix branch March 4, 2024 19:34
pjhill pushed a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants