New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VYE-226 #28291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew565
previously approved these changes
Mar 1, 2024
micahchiang
approved these changes
Mar 4, 2024
Adding new JSON-SCHEMA master hash commit
Updating with new JSON-SCHEMA master hash commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to update the JSON-Schema commit hash to align with JSON-SCHEMA repo updates. No other changes are in this PR
JSON-SCHEMA PR -> department-of-veterans-affairs/vets-json-schema#850
VETS-API PR -> As soon as this PR is approved and merge we will create the VETS-API PR with the new build pointing to the master hash commit of the updated JSON-SCHEMA
DRAFT PR that will be rebuilt once JSON-SCHEMA is in master -> https://github.com/department-of-veterans-affairs/vets-api/pull/15755/files
Related issue(s)
department-of-veterans-affairs/va.gov-team#0000
department-of-veterans-affairs/vets-website#0000
department-of-veterans-affairs/va.gov-team#0000
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websites
Slack channel for questionsRequested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?