Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VYE-226 #28291

Merged
merged 4 commits into from Mar 4, 2024
Merged

VYE-226 #28291

merged 4 commits into from Mar 4, 2024

Conversation

jsimonVA
Copy link
Contributor

@jsimonVA jsimonVA commented Mar 1, 2024

Summary

This PR is to update the JSON-Schema commit hash to align with JSON-SCHEMA repo updates. No other changes are in this PR

image

image

JSON-SCHEMA PR -> department-of-veterans-affairs/vets-json-schema#850

VETS-API PR -> As soon as this PR is approved and merge we will create the VETS-API PR with the new build pointing to the master hash commit of the updated JSON-SCHEMA
DRAFT PR that will be rebuilt once JSON-SCHEMA is in master -> https://github.com/department-of-veterans-affairs/vets-api/pull/15755/files

  • (Summarize the changes that have been made to the platform)
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

  • Link to ticket created in va.gov-team repo
    department-of-veterans-affairs/va.gov-team#0000
  • Link to previous change of the code/bug (if applicable)
    department-of-veterans-affairs/vets-website#0000
  • Link to epic if not included in ticket
    department-of-veterans-affairs/va.gov-team#0000

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Andrew565
Andrew565 previously approved these changes Mar 1, 2024
@jsimonVA jsimonVA merged commit 316b0e6 into main Mar 4, 2024
61 checks passed
@jsimonVA jsimonVA deleted the VYE-226 branch March 4, 2024 19:26
pjhill pushed a commit that referenced this pull request Mar 14, 2024
* #VYE-226 #comment updated package json with new commit hash

* #VYE-226 #comment updated commit hash in package.json for latest JSON commit

* Update package.json

Adding new JSON-SCHEMA master hash commit

* Update yarn.lock

Updating with new JSON-SCHEMA master hash commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants