Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(spike) added user to rum #28214

Merged
merged 12 commits into from Mar 11, 2024
13 changes: 11 additions & 2 deletions src/applications/mhv/secure-messaging/containers/App.jsx
@@ -1,4 +1,4 @@
import React, { useEffect } from 'react';
import React, { useEffect, useMemo } from 'react';
import { useDispatch, useSelector } from 'react-redux';
import { Switch } from 'react-router-dom';
import { selectUser } from '@department-of-veterans-affairs/platform-user/selectors';
Expand All @@ -14,7 +14,7 @@
import Navigation from '../components/Navigation';
import ScrollToTop from '../components/shared/ScrollToTop';
import { useDatadogRum } from '../../shared/hooks/useDatadogRum';
import { getAllTriageTeamRecipients } from '../actions/recipients';

Check warning on line 17 in src/applications/mhv/secure-messaging/containers/App.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed)

src/applications/mhv/secure-messaging/containers/App.jsx:17:1:Importing from platform via platform/monitoring is deprecated. Import from @department-of-veterans-affairs/platform-monitoring instead or check babel.config.json for an alias to the import.

const App = () => {
const dispatch = useDispatch();
Expand Down Expand Up @@ -56,7 +56,16 @@
trackLongTasks: true,
defaultPrivacyLevel: 'mask-user-input',
};
useDatadogRum(datadogRumConfig);
const userDetails = useMemo(
() => {
return {
loggedIn: user.login.currentlyLoggedIn,
accountUuid: user.profile.accountUUid,
};
},
[user.login.currentlyLoggedIn, user.profile.accountUUid],
mdewey marked this conversation as resolved.
Show resolved Hide resolved
);
useDatadogRum(datadogRumConfig, userDetails);

if (featureTogglesLoading) {
return (
Expand Down
9 changes: 7 additions & 2 deletions src/applications/mhv/shared/hooks/useDatadogRum.jsx
Expand Up @@ -20,12 +20,17 @@ const initializeDatadogRum = config => {
}
};

const useDatadogRum = config => {
const useDatadogRum = (config, userInfo) => {
useEffect(
() => {
initializeDatadogRum(config);
if (userInfo.loggedIn && environment.isStaging()) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: if this works in, staging. We can explore adding a feature flag vs just turning it on.

datadogRum.setUser({
id: userInfo.accountUuid || 'no-account-uuid-found',
});
}
},
[config],
[config, userInfo],
);
};

Expand Down