[Rated Disabilities] - Migrate v1 components to v3 components #28163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmclaren19
added
benefits-team-1
benefits-management-tools
va-vfs-bot
temporarily deployed
to
master/76124-Rated-Disabilities-migrate-v1-components-to-v3-components/main
va-vfs-bot
temporarily deployed
to
master/76124-Rated-Disabilities-migrate-v1-components-to-v3-components/main
|
Added code changes. Blocked on merging until platform team merges their pr on 3/4 @HeatherWidmont @jacobworrell |
|
@skylerschain please review these changes before we merge on 3/4 and let me know if you have any questions. |
|
Images LGTM 👍 |
samcoforma
previously approved these changes
Feb 26, 2024
micahchiang
previously approved these changes
Feb 27, 2024
pmclaren19
dismissed stale reviews from micahchiang and samcoforma
via
164dccd
…ts-to-v3-components
micahchiang
previously approved these changes
Mar 18, 2024
samcoforma
requested changes
Mar 18, 2024
samcoforma
approved these changes
Mar 18, 2024
micahchiang
approved these changes
Mar 18, 2024
pmclaren19
deleted the
76124-Rated-Disabilities-migrate-v1-components-to-v3-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the following files to no longer have
uswds='false'Tested the following files that have V3 components with
uswds='true'defaultedUpdated the following files that already have
uswds='true'to no longer have that and use the default trueRelated issue(s)
[Rated Disabilities] v3 component migration va.gov-team#76124
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
Rated Disabilities
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websitesSlack channel for questionsRequested Feedback
Steps to repo MVIError.jsx - default => I had to override the code to get this one to display
Steps to repo RatedDisabilityList.jsx - default => go to user vets.gov.user+0@gmail.com
Steps to repo RatedDisabilityList.jsx - error => I had to override the code to get this one to display
Steps to repo SortSelect.jsx => ratedDisabilitiesSortAbTest feature flag is enabled
Steps to repo TotalRatingStates.jsx - info => go to user vets.gov.user+0@gmail.com
Steps to repo TotalRatingStates.jsx - va-summary-box => go to user vets.gov.user+1@gmail.com
Steps to repo TotalRatingStates.jsx - error => I had to override the code to get this one to display