Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configs webpack to move component-library assets to build #28121

Merged
merged 7 commits into from Mar 7, 2024
Merged

Configs webpack to move component-library assets to build #28121

merged 7 commits into from Mar 7, 2024

Conversation

rmessina1010
Copy link
Contributor

@rmessina1010 rmessina1010 commented Feb 22, 2024 •
edited by jamigibbs

Summary

  • Update webpack config file to copy assets from component-library into build. This solves issue with svgs not loading in some va-web-components

Related issue(s)

Testing done

  • tested local install, with and without Verdaccio
  • visual testing in V3-playground
  • unit tests

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

  • Should we also consider that assets already reside in the sites/asset directory?
  • Please install locally and test

@va-vfs-bot va-vfs-bot temporarily deployed to master/rm-svg-assets-move/main March 6, 2024 20:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/rm-svg-assets-move/main March 6, 2024 21:41 Inactive
@rmessina1010 rmessina1010 marked this pull request as ready for review March 6, 2024 22:46
@rmessina1010 rmessina1010 requested review from a team as code owners March 6, 2024 22:46
micahchiang
micahchiang approved these changes Mar 6, 2024
View reviewed changes
config/webpack.config.js
{
from:
'node_modules/@department-of-veterans-affairs/component-library/dist/assets',
to: `${buildPath}/assets`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice. This was the part I had wrong in my own research. I think I was specifying src/assets or something hard coded instead of buildPath

@rmessina1010 rmessina1010 merged commit 4251e24 into main Mar 7, 2024
61 checks passed
@rmessina1010 rmessina1010 deleted the rm-svg-assets-move branch March 7, 2024 15:10
pjhill pushed a commit that referenced this pull request Mar 14, 2024
@rmessina1010
Configs webpack to move component-library assets to build (#28121)
f220e84 
* configures webpack to copy assets into build directory

* uptates ds-v3-playground to show pagination with svg

* bump component-library to 37.2.0

* synch code owners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahchiang micahchiang micahchiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmessina1010 @micahchiang @va-vfs-bot