[Letters] - Update letters so V1 components are V3 components

[pmclaren19]

Summary

Updated the following files to no longer have uswds='false'

• src/applications/letters/components/AppContent.jsx
• src/applications/letters/components/DownloadLetterLink.jsx
• src/applications/letters/components/NoAddressBanner.jsx
• src/applications/letters/components/systemDownMessage.jsx
• src/applications/letters/containers/DownloadLetters.jsx
• src/applications/letters/containers/LetterList.jsx
• src/applications/letters/containers/Main.jsx
• src/applications/letters/containers/VeteranBenefitSummaryLetter.jsx
• src/applications/letters/utils/helpers.jsx

Related issue(s)

• Link to ticket created in va.gov-team repo
  [Letters] migrate to v3 components va.gov-team#76123

Testing done

• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected
• Describe the tests completed and the results
• _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
• Optionally, provide a link to your test plan and test execution records

Screenshots

_Note: Tried to get screenshots but was unable to repro certain things in localhost/staging

	Before	After
NoAddressBanner.jsx va-alert
DownloadLetters.jsx va-segmented-progress-bar
LetterList.jsx va-accordion
LetterList.jsx va-telephone
DownloadLetterLink.jsx va-alert success
Systemdownmessage.jsx va-alert
helpers va-alert
VeteranBenefitSummaryLetter.jsx va-table
AppContent.jsx va-alert

What areas of the site does it impact?

Letters

Acceptance criteria

• Any components that were updated as USWDS false that are not V3 components should have that prop removed.
• Design and engineering test locally to confirm design fidelity of the migration before changes are merged

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

• The vets-website header does not contain any web-components
• I used the proxy-rewrite steps to test the injected header scenario
• I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

How to test things

• AppContent.jsx , go to user 30 https://staging.va.gov/records/download-va-letters/letters/
• DownloadLetters.jsx va-segmented-progress-bar, go to user 46 https://staging.va.gov/records/download-va-letters/letters/confirm-address
• LetterList.jsx va-accordion, va-telephone, go to user 46 https://staging.va.gov/records/download-va-letters/letters/letter-list
• DownloadLetterLink.jsx va-alert success, go to user 46 and download a letter from https://staging.va.gov/records/download-va-letters/letters/letter-list
• Systemdownmessage.jsx va-alert, unable to repo in staging
• helpers va-alert, go to user 46 and open the Service Verification Letter https://staging.va.gov/records/download-va-letters/letters/letter-list
• VeteranBenefitSummaryLetter.jsx va-table, go to user 46 and open the Benefit Summary and Service Verification Letter https://staging.va.gov/records/download-va-letters/letters/letter-list