Fix v3-web-component va-segmented-progress-bar Safari focus bug #27784
+335
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
tlei123
changed the title
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
powellkerry
previously approved these changes
Feb 5, 2024
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
|
When I check out this branch locally and test it with the Pension benefits application (/pension/application/527EZ), the issue still persists on Safari. Chrome also appears to have the issue too, where it didn't before. I've made sure to check out the latest commit b059f87. Are there any steps I'm missing to run the fix locally? |
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
|
If we switch the Pension benefits application uiSchema titles from |
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
Mottie
approved these changes
Mar 4, 2024
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
micahchiang
approved these changes
Mar 4, 2024
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
va-vfs-bot
temporarily deployed
to
master/simple-forms/978-safari-focus-2/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
department-of-veterans-affairs/va.gov-team-forms#978
Testing done
What areas of the site does it impact?
All forms with
useCustomScrollAndFocusprop enabled, on Safari only.Requested feedback
@Mottie , please be sure to review & approve. I couldn't make you required-reviewer here, but I'm definitely gonna wait for your Approval before Merging. Thanks much! :)